max-mapper / max-mapper/workerstream

Doesn't pass `stream-spec` standardized test

Open
#6 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
92
Forks
14
PR merge metrics
No merged PRs in 30d

Description

@dominictarr's [stream-spec](https://github.com/dominictarr/stream-spec) for testing stream implementations

``` js
var WebWorkify = require('webworkify')
var WorkerStream = require('../index.js')
var spec = require('stream-spec')

var worker = WebWorkify(require('./ps-loopback-worker.js'))
var workerStream = WorkerStream(worker)

spec(workerStream)
.through({strict: true})
.validateOnExit()
```

results in

```
Uncaught AssertionError: stream *must* have pause
```

I'm sure there are other assertions once you get past this one.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Run the stream-spec example from the issue against index.js, beginning with WorkerStream and the ps-loopback-worker.js fixture. Use the reported missing pause assertion as the first checkpoint; done means the worker stream passes the chained through({strict: true}).validateOnExit() checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
backend, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.