max-mapper / max-mapper/websocket-stream
"stream" vs "connection"
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 667
- Forks
- 110
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/maxogden/websocket-stream/blob/master/server.js#L18
FYI, we had to do the opposite trick: "connection" is a standard event we expect from a server, so
https://github.com/gritzko/stream-url-ws/blob/master/index.js#L21
Probably you should emit both?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with server.js at line 18 and compare its event naming with the referenced stream-url-ws index.js at line 21. Determine whether websocket-stream should emit both "stream" and "connection"; the work is done when the server exposes the expected event names consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- backend, networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 38/100