max-mapper / max-mapper/websocket-stream
Allow text frames
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 667
- Forks
- 110
- PR merge metrics
- No merged PRs in 30d
Description
The new 1.0 version seems to only send binary WebSocket frames now, because a `Buffer` instance is always passed directly to `socket.send()`.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the 1.0 WebSocket send path where a Buffer is passed to socket.send(). Check how text and binary frames are distinguished, then add coverage for sending text frames. Done means text input is sent as a text WebSocket frame while binary input remains binary.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100