max-mapper / max-mapper/websocket-stream

test-client.js throws when testing

Open
#44 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
667
Forks
110
PR merge metrics
No merged PRs in 30d

Description

I get the following error when testing the client:

```
Error: Cannot find module 'websocket-stream'
```

It comes about because of the first line in test-client:

```
var ws = require('websocket-stream')
```

I'm guessing you have your development environment set up so this works (perhaps by using npm link?). Should this line be changed to:

```
var ws = require('./')
```

or instructions be added to correctly set up the development environment?

Thanks for all the great work!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with test-client.js and inspect its first require of websocket-stream, then check how the package's development dependencies and local module entry point are configured. Done means the client test no longer fails with the missing-module error using the documented or repository-supported setup.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.