max-mapper / max-mapper/websocket-stream
Error event judgement in file 'stream.js'
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 667
- Forks
- 110
- PR merge metrics
- No merged PRs in 30d
Description
> // according to https://github.com/baygeldin/ws-streamify/issues/1
// Nodejs WebSocketServer cause memory leak
// Handlers like onerror, onclose, onmessage and onopen are accessible via setter/getter
// And setter first of all fires removeAllListeners, that doesnt make inner array of clients on
var eventListenerSupport = ('undefined' === typeof socket.addEventListener)
The sign ‘===’ in this line of code should change to ‘!==’.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open stream.js and locate the eventListenerSupport assignment shown in the issue. Confirm the comparison is reversed, change === to !==, and verify the resulting behavior with the project's available checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100