max-mapper / max-mapper/websocket-stream

Error event emits without error object

Open
#138 29 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
667
Forks
110
PR merge metrics
No merged PRs in 30d

Description

In my videomail client code this strange thing sometimes happens: no error object is emited along with the error event.

Like

stream.on('error', function (err) {
  console.log(err) // this will print undefined
})

Don't you agree, it should have an error object? An error without an error is not an error :)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start by reproducing the stream.on('error') case from the issue and trace where websocket-stream emits the error event. Done means the event consistently provides an error object in the reported scenario, with a regression test covering it.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.