Is the usage of Int8Array instead of Uint8Array intentional?
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 192
- Forks
- 39
- PR merge metrics
- No merged PRs in 30d
Description
I am wondering if the usage of Int8Array as the underlying voxel array type intentional? This means that materials > 127 will end up as negative values, which means they cannot be used directly as indexes to any materials array lookup. A simpler choice would seem to just declare it as Uint8Array.
Perhaps there is some magic performance reason for this, but I do not know of any.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the declaration of the underlying voxel array and trace how its values are used for material lookup. Check the behavior for material values above 127; done means the signedness choice is resolved and those values can be handled correctly, with relevant tests or verification added if the repository provides them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- computer-graphics, game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100