max-mapper / max-mapper/tape-spawn

t.end is called when onDone is passed

Open
#11 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
23
Forks
3
No merged PRs in 30d

Description

According to the docs:

if you pass the optional onDone callback, no t.end() assertion will be created...

but the code does not work that way:

if (self.opts.end !== false) self.t.end()
if (onDone) onDone()

Which is correct?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the documented spawnTest end/onDone behavior with the implementation in index.js at lines 45-46. Determine which behavior the project intends, then align the documentation and implementation so they agree. Check the repository's existing test setup for a suitable verification path.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.