max-mapper / max-mapper/nugget

nugget fails in a Travis CI environment with a memory leak

Open
#25 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
178
Forks
29
PR merge metrics
No merged PRs in 30d

Description

The progress bar does weird stuff and it causes Travis CI to run out of memory when something else calls nugget while in a coverage check with Instanbul, but only when using async Mocha and calling from within a promise.

Don't ask me why or how.

The solution to stop the leak is to make sure opts.quiet is set i.e. my code now looks like:

    var isInCI = process.env.CI !== undefined
    nugget([link], { dir: tmpDir, quiet: isInCI }, function () {
      isFunction(onDone) && onDone(fullName)
    })

It fails on Linux and OS X images, with all versions of node back to 4.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the nugget call described in the issue under async Mocha, Istanbul coverage, and Travis CI on the Linux or OS X environments mentioned. Compare behavior with and without opts.quiet; done means the memory leak is addressed without requiring callers to use the workaround, while progress-bar behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.