max-mapper / max-mapper/nugget

Request to upgrade dependency - progress-stream

Open
#23 3 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
178
Forks
29
PR merge metrics
No merged PRs in 30d

Description

Could you please upgrade progress-stream dependency to 2.0.0?

I ask this because while installing electron (latest stable, 1.6.2), yarn emits the following warning:

warning electron > electron-download > nugget > progress-stream > through2 > xtend > object-keys@0.4.0

On further investigation, this seems to be happening because object-keys@0.4.0 seems to be deprecated. Checking through the transitive dependencies, progress-stream till 1.2.0 has an old dependency on through2. In 1.2.1, progress-stream has upgraded its dependencies, which removes the deprecated object-keys. For some unknown reason, 1.2.1 has not been published in npm. Only the 2.0.0 version has been published, which incidentally does not seem to have any difference with 1.2.1.

Thanks.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the dependency declaration for progress-stream and inspect the installed dependency tree that produces the object-keys warning. Update the declaration to 2.0.0, then verify that installation no longer pulls the deprecated object-keys version and that the existing test or package checks still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
cli
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.