max-mapper / max-mapper/node-repl
Error when no trailing newline last line in file is a comment
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 127
- Forks
- 12
- PR merge metrics
- No merged PRs in 30d
Description
If the last line in the file that is passed to node-repl is a // comment , AND there is no newline at the end of the file the code breaks with:
SyntaxError: Unexpected token }
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running node-repl with a file whose final line is a // comment without a trailing newline, and confirm the reported SyntaxError. Trace how node-repl passes the file to the parser, then add coverage for this input and verify that it no longer fails.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100