max-mapper / max-mapper/monu

escape quotes in commands

Open
#35 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
CSS
Stars
1.1k
Forks
69
PR merge metrics
No merged PRs in 30d

Description

If you add to your config e.g. bash -c "echo foo", it gets turned into mon "bash -c "echo foo"" which means the inner quotes essentially get ignored and the running process will look like mon bash -c echo foo, when it should look like mon bash -c "echo foo".

The fix is to escape the inner quotes, the user can do this manually but I think we should probably do this for them. I wonder if it is as simple as simply replacing " with \"?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how configured commands are assembled into the displayed or launched mon command. Use the bash -c "echo foo" example to verify the current quoting behavior; done means the inner quotes remain part of the command rather than being ignored.

Written by the indexing model from the issue text.

Assessment

Tech stack
bash
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.