max-mapper / max-mapper/monocles

BrowserID login broken!

Open
#36 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
178
Forks
15
PR merge metrics
No merged PRs in 30d

Description

It looks like monocles was bitten by a recent API change we made to browserid. The fix is simply to send assertions to the verifier using POST instead of GET. Here's a blog post from the moz identity dudes about the change:

http://identity.mozilla.com/post/11638168358/note-to-implementers-we-changed-the-verifier-api

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the BrowserID login code that sends assertions to the verifier, then read the linked Mozilla identity API-change post for the expected request method. Done means BrowserID login works again against the changed verifier API, with any existing login checks still passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
authentication
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.