max-mapper / max-mapper/minecraft-skin
UV Mapping fails in modern versions of Three.js
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 57
- Forks
- 19
- PR merge metrics
- No merged PRs in 30d
Description
I've just tried this out with a modern version of Three.js and got an error around line 142...
uvs[ (3 + rotateBy) % 4 ].x = (tileU * tileUvWidth + w * tileUvWidth)
I'm guessing the mesh building code has changed in three.js and it breaks the UVs somehow - but I don't really know what I'm doing so I couldn't work out how to fix it. :( It still works if you disable uv mapping, but then the man obviously looks retarded.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the failure with UV mapping enabled and inspect the UV assignment around line 142, especially the access to uvs[(3 + rotateBy) % 4]. Compare the mesh and UV APIs used by this project with the modern Three.js version. Done means the skin mesh builds without the error and its UV-mapped appearance is correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, three.js
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100