max-mapper / max-mapper/menubar
preloadWindow makes dock icon always shows on macOS
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 6.8k
- Forks
- 363
- PR merge metrics
- No merged PRs in 30d
Description
Description
On Electron 9.3.0. Setting preloadWindow to true will cause dock icon to be shown even if showDockIcon is set to false (default). It works correctly on Electron 9.2.1
Steps to Reproduce the Problem
const { menubar } = require('menubar');
const mb = menubar({
preloadWindow: true,
});
mb.on('ready', () => {
console.log('Menubar app is ready.', process.versions.electron);
});
Expected Behaviour
Dock icon is hidden
Actual Behaviour
Dock icon is shown
Specifications
- Menubar version: 9.0.1
- Platform: macOS
- Electron version: 9.3.0
Other information
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with Electron 9.3.0 using the menubar configuration shown, then trace how preloadWindow and showDockIcon are handled. Confirm the behavior against Electron 9.2.1 and identify the relevant entry point; done means preloadWindow no longer shows the macOS dock icon when showDockIcon is false.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- electron, macos
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100