max-mapper / max-mapper/level-row-versioning-benchmarks

use \x00 between ID and version instead of \xff

Open
#2 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
14
Forks
0
PR merge metrics
No merged PRs in 30d

Description

using a late sorting separator will only work right if you have fixed length ids.
but an early sorting separator will enable you to have variable length, or fixed length ids. if you use a late sorting separator, short keys will sort after long keys.
a\xff will be after aa\xff, which is wrong.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the JavaScript code that constructs the LevelDB key from the ID and version. Check its ordering behavior with variable-length IDs, including the a and aa examples from the issue. Done means the separator is \x00 and keys sort correctly for both variable- and fixed-length IDs.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
databases
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.