max-mapper / max-mapper/github-oauth
Why not allow the "(no scope)" scope?
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 71
- Forks
- 20
- PR merge metrics
- No merged PRs in 30d
Description
If I'm reading https://developer.github.com/v3/oauth/#scopes right, specifying an empty scope is a read-only permission (but still an authentication, meaning it isn't subject to the rate limiting of anonymous requests).
If I'm reading https://github.com/maxogden/github-oauth/blob/master/index.js#L10 correctly, the code as written makes it impossible to specify that minimal scope.
What am I missing?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with index.js at the OAuth scope handling referenced in the issue and compare its behavior with GitHub's documented empty-scope semantics. Confirm how an omitted or empty scope is passed through, then verify that the minimal read-only authenticated flow can be requested without being treated as an anonymous request.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, javascript, node.js
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100