max-mapper / max-mapper/extract-zip
Windows requires admin rights for creating symlinks
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 398
- Forks
- 144
- PR merge metrics
- No merged PRs in 30d
Description
This throws when I'm not running node as admin: https://github.com/maxogden/extract-zip/blob/master/index.js#L152
I think a sane fallback would be to just copy the file contents of the original file. This is what windows' native unzip does, afaik.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at index.js line 152 and inspect how symlink entries are created during extraction. Reproduce extraction on Windows without administrator rights, then verify that the affected entry is copied successfully instead of throwing when symlink creation is unavailable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100