max-mapper / max-mapper/extract-zip
the extract method does not return an error event if the extraction fails. Abruptly crashes node.
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 398
- Forks
- 144
- PR merge metrics
- No merged PRs in 30d
Description
async function main () {
try {
await extract(source, { dir: target })
console.log('Extraction complete')
} catch (err) {
// handle any errors
}
}
using this method with node 16.18.0 and a callback function does not return error or finish. This results in abruptly crashing node. Please provide good documentation and implementation of the callback function and investigate this bug. For specific cases, neither the finish nor the error event is fired within the writeStream function
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the extract(source, { dir: target }) entry point and trace the callback and writeStream handling described in the report. Reproduce the failure on Node 16.18.0 with an extraction error, then verify that the documented callback receives the error or completion event without abruptly crashing Node.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100