max-mapper / max-mapper/extract-zip
add electron mac, linux and windows zips as test cases
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 398
- Forks
- 144
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/maxogden/extract-zip/issues/10 was caused by not testing the linux and windows electron zips, we should add them to the test suite. I tested the mac one manually but it should get added too
I don't mind the test suite of this having to download the 100mb+ needed for this issue if it means more stability
I think the tests should extract them, and then test that certain files were created. I'm not sure exactly which files to test yet, but if someone wants to tackle this, just start with something basic
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the repository's existing test suite and how it obtains ZIP fixtures. Add Electron ZIP cases for macOS, Linux, and Windows, extract each archive, and assert that representative files are created; the tests should cover the regression described in issue #10.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100