max-mapper / max-mapper/electron-spawn
Doesn’t work with whitespace in filename
Open
Nobody has claimed this yet.
help wanted
- Dominant language
- JavaScript
- Stars
- 195
- Forks
- 18
- PR merge metrics
- No merged PRs in 30d
Description
Hi, the JS API seems to have problems executing a file with whitespace in its path.
To reproduce:
▸ git clone git@gist.github.com:7fbe4fafe896bbb96679.git
▸ npm install
▸ node -e "require('electron-spawn')('no-space.js').stdout.pipe(process.stdout)"
◂ ok
# This is alright.
▸ node -e "require('electron-spawn')('with space.js').stdout.pipe(process.stdout)"
# The `ok` never comes!
The contents of no-space.js and with space.js are identical.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the two commands from the issue with no-space.js and with space.js, using the linked gist for their identical contents. Trace the electron-spawn entry point that handles the filename and verify that both files execute and produce the expected ok output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- electron, javascript
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100