max-mapper / max-mapper/docker-stream

handle stderr

Open
#2 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
68
Forks
1
PR merge metrics
No merged PRs in 30d

Description

right now stderr of the `docker run` command is ignored. this is probably gonna break the JS API

right now the constructor returns a stream. what if the JS API returned an object like child_process.spawn w/ stdin, stdout, stderr?:

``` js
var dockerStream = require('docker-stream')
var run = dockerStream('dat-docker-example')
// {stdout: stream, stderr: stream, stdin: stream}
```

I guess I could make all three of the streams duplexify instances...

cc @mafintosh

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start at the constructor that launches `docker run` and trace how stderr is currently handled. Clarify the proposed stdin, stdout, and stderr stream API, then verify that stderr is exposed without breaking the existing stream behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, javascript
Domain
api, cli
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.