max-mapper / max-mapper/docker-stream

handle stdin correctly

Open
#1 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
68
Forks
1
PR merge metrics
No merged PRs in 30d

Description

in this first implementation of docker-stream this works:

cat test.json | docker-stream dat-docker-example

but this hangs:

docker-stream dat-docker-example

@mafintosh do you have ideas on how I should be handling stdin?

references:

https://github.com/maxogden/docker-stream/blob/master/cli.js
https://github.com/maxogden/docker-stream/blob/master/index.js#L44-L59

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the two commands in cli.js and trace the stdin handling referenced in index.js lines 44-59. Compare piped and non-piped execution, then verify that docker-stream dat-docker-example no longer hangs while the existing cat test.json | docker-stream dat-docker-example behavior still works.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, javascript
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.