max-mapper / max-mapper/csv-write-stream

Shouldn't need headers when writing array.

Open
#19 2 comments 11 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
203
Forks
34
PR merge metrics
No merged PRs in 30d

Description

Currently, if there are no headers and `sendHeaders: false` is specified, writing an array results in `Error: no headers specified`. However, in this situation can we not just write the array directly?

If it is simplest to implement this way, perhaps, call `_compile` with a range of indexes corresponding to elements in the first row sent?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the no-headers, sendHeaders:false case described here and inspect the array-writing path. Add a regression test showing that an array is written directly without headers, and use it to confirm the error is gone.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.