max-mapper / max-mapper/concat-stream
Use standard, error-first callbacks
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 574
- Forks
- 61
- PR merge metrics
- No merged PRs in 30d
Description
Drawn from #15. Let's discuss in a separate issue.
jonathanong on Dec 1, 2013
callback(err, data)- it's a callback, not an event listener, so imo it should haveerras the first argument. however,errshould always benullsince concat-stream should never have any errors (i get #6 (comment)) unless we decide to throw errors when there are crazy typing issues. we can do crazy stuff like checklistener.lengthbut i'm not a fan of that either.
substack on Dec 23, 2013
cb(err, data)is annoying if there isn't ever an error. Why not just omit that parameter like it presently is?
jeromew on Jan 13, 2014
[...] don't understand "concat-stream should never have any errors" because shouln't concat-stream handle the errors of the underlying streams to report via cb(err, data) ?
zenflow on June 29, 2015 (just now)
If you pipe a readable stream to this or any other writable stream (with Readable.protototype.pipe), errors will not be piped downstream along with the data.
When using this library, you must handle upstream errors yourself
Besides any upstream errors, there are no other errors to expect.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the callback behavior described in this issue and the linked discussion from #15. No file, test, or entry point is named; completion would require a settled decision on whether callbacks use an error-first signature and how errors should be handled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100