max-mapper / max-mapper/concat-stream

concat-stream - buffer object in callback is empty.

Open
#31 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
574
Forks
61
PR merge metrics
No merged PRs in 30d

Description

See the following piece of code.

   var  concat = require('concat-stream');
   var src = // some stream which contains non-utf-8 content for ex : shift_jis
   var dest = // it is destination stream
   var concatStream = concat(function(buffer)) {
     // buffer is empty string here. It is not readable while debugging as well.
    // I want to do some modifications in this buffer.
    dest.write(buffer);
    dest.close();
   }

On browser I see response is coming back but none of the modifications were made to the content. If I try to debug buffer is empty string in callback.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Begin with the concat-stream callback shown in the issue and reproduce it using the reported non-UTF-8 stream case. Compare the callback value with the data written to dest and verify whether modifications are preserved in the browser scenario; the issue is done when the callback no longer yields the reported empty value.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
stream-processing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.