max-mapper / max-mapper/callback-hell
Can you add some words on how callback arguments get set
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 858
- Forks
- 101
- PR merge metrics
- No merged PRs in 30d
Description
Thanks for doing this!
Something which throws me whenever I look at callback code, is where the "err, response, body" arguments to postResponse come from. I feel like this is a stumbling block for many people. Thanks again!
var name = document.querySelector('input').value
request({
uri: "http://example.com/upload",
body: name,
method: "POST"
}, postResponse)
}
function postResponse(**err, response, body**) { // <<<<<< here
var statusMessage = document.querySelector('.status')
if (err) return statusMessage.value = err
statusMessage.value = body
}
document.querySelector('form').onsubmit = formSubmit
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the callback example in the issue and the repository's surrounding documentation to find where this explanation belongs. Add a clear explanation of where err, response, and body passed to postResponse come from, then verify that the example is understandable to readers unfamiliar with callback arguments.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100