Export the filter
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 368
- Forks
- 89
- PR merge metrics
- No merged PRs in 30d
Description
First of all nice and well designed library!
I am looking to add a export() method.
From my test looks like is enough to just move
bits_.data()
and
num_bits_
For this "test" I have just moved as public
bitvector bits_;
and
size_type num_bits_;
std::vector<block_type> bits_;
If is ok I will prepare a patch to add serialize / unserialize function.
They will be something like
std::string serialize();
bool unserialize(std::string raw)
The result "string" will be nothing more than sizeof(size_type) byte for the num_bits_ and all the remaining the content of bits_.data().
Eventually a checksum can be added, there is no need to have a base64 version, I don't think someone is going to copy paste a filter.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the library's bitvector representation, especially bits_, bits_.data(), and num_bits_. Evaluate the proposed serialize() and unserialize(std::string raw) interface and its byte layout, including whether a checksum is needed; done means the format and round-trip behavior are agreed and implemented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- data
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100