Didnt work on 2.15.1

Open

#4 opened on Jul 12, 2019 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language: PHP
Stars: 1
Forks: 6
PR merge metrics: No merged PRs in 30d

Description

while giving API key throwing this error

2019-06-20 13:19:51] mautic.ERROR: PHP Notice: Declaration of MauticPlugin\MauticMessageBirdBundle\Services\MessageBirdApi::sendSms($number, $content) must be compatible with Mautic\SmsBundle\Api\AbstractSmsApi::sendSms(Mautic\LeadBundle\Entity\Lead $lead, $content) - in file /home/plugins/MauticMessageBirdBundle/Services/MessageBirdApi.php - at line 161 [] []
[2019-06-20 13:19:51] mautic.ERROR: Symfony\Component\Debug\Exception\FatalErrorException: Notice: Declaration of MauticPlugin\MauticMessageBirdBundle\Services\MessageBirdApi::sendSms($number, $content) must be compatible with Mautic\SmsBundle\Api\AbstractSmsApi::sendSms(Mautic\LeadBundle\Entity\Lead $lead, $content) - in file /home/plugins/MauticMessageBirdBundle/Services/MessageBirdApi.php - at line 161 [] []
[2019-07-12 13:19:51] mautic.CRITICAL: Uncaught PHP Exception Symfony\Component\Debug\Exception\FatalErrorException: "Compile Error: Declaration of MauticPlugin\MauticMessageBirdBundle\Services\MessageBirdApi::sendSms($number, $content) must be compatible with Mautic\SmsBundle\Api\AbstractSmsApi::sendSms(Mautic\LeadBundle\Entity\Lead $lead, $content)" at /home/plugins/MauticMessageBirdBundle/Services/MessageBirdApi.php line 161 {"exception":"[object] (Symfony\\Component\\Debug\\Exception\\FatalErrorException(code: 0): Compile Error: Declaration of MauticPlugin\\MauticMessageBirdBundle\\Services\\MessageBirdApi::sendSms($number, $content) must be compatible with Mautic\\SmsBundle\\Api\\AbstractSmsApi::sendSms(Mautic\\LeadBundle\\Entity\\Lead $lead, $content) at /home/plugins/MauticMessageBirdBundle/Services/MessageBirdApi.php:161)"} []

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Research direction

Start in /home/plugins/MauticMessageBirdBundle/Services/MessageBirdApi.php at line 161 and compare MessageBirdApi::sendSms($number, $content) with Mautic\SmsBundle\Api\AbstractSmsApi::sendSms(Mautic\LeadBundle\Entity\Lead $lead, $content). Reproduce the API-key flow on Mautic 2.15.1 and confirm it no longer raises the reported declaration-compatibility error.

Written by the indexing model from the issue text.

Assessment

Tech stack: php
Domain: api, backend
Issue type: Bug
Difficulty: 2/5
Estimated time: 1-3 hours
Activity status: Stale
Clarity: Mostly clear
Newbie friendliness: 35/100