mattpolzin / mattpolzin/jsonapi-openapi-test-server
Fix bug where messages relationship on APITestDescriptor is returned unconditionally
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 6
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
The messages relationship should only result in serialized message resource objects included if they are requested. Right now they will always be included because there is not a concise way to grab the IDs of related messages without grabbing the whole row.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating APITestDescriptor and its messages relationship serialization. Check how requested relationships are determined and how related message IDs are obtained; done means message resource objects are included only when messages is requested, without unconditionally loading the whole row.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100