Revisiting process termination on OSX/Linux
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 25
- Forks
- 6
- PR merge metrics
- No merged PRs in 30d
Description
I suggested to use SIGINT as signal for currentProcess.kill('SIGINT'); but ever since that was changed it stopped working for me at all. Today I had some time to investigate and found "no possible solution" to make it work with SIGINT which is afais caused by using the /bin/sh shell approach to run the programs. But even if that would not where the case, there are a multitude of problems when complex runner scripts are involved. So I think it is bet to revert to the previous currentProcess.kill(); version.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the runner code that calls currentProcess.kill('SIGINT') and compare it with the previous currentProcess.kill() behavior. Reproduce termination on OSX/Linux, including programs launched through /bin/sh and complex runner scripts. Done means process termination works reliably in those cases and the relevant behavior is covered by the project's available checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100