Unit tests fail in 3.4.0
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 33
- Forks
- 31
- PR merge metrics
- No merged PRs in 30d
Description
Two unit tests fail when building MRuby 3.4.0 against this gem:
- There is a syntax error in
test/json.rb:148that is almost certainly due to the parser becoming more correct. The expression in question isJSON.load '{' {|x| o = x}; putting parens around the argument toloadfixed the problem. - On line 35, the output differs from the expected output only by insignificant whitespace. I'm not sure why this changed, but the result is still correct.
I've fixed this and will submit a pull request.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test/json.rb at lines 35 and 148, then run the unit-test suite against MRuby 3.4.0. Done means both previously failing tests pass, with the expected output matching despite insignificant whitespace differences.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100