mattn / mattn/mruby-http

warning: 'mrb_http_object_headers_set_item' defined but not used

Open
#15 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
28
Forks
19
PR merge metrics
No merged PRs in 30d

Description

I get the following warning when compiling `mruby-http`:

```
/home/mruby/code/mruby/build/mrbgems/mruby-http/src/mrb_http.c:47:35: warning: unused variable 'http_url_type' [-Wunused-const-variable]
static const struct mrb_data_type http_url_type = {

/home/mruby/code/mruby/build/mrbgems/mruby-http/src/mrb_http.c:490:1: warning: 'mrb_http_object_headers_set_item' defined but not used [-Wunused-function]
mrb_http_object_headers_set_item(mrb_state *mrb, mrb_value self)
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting src/mrb_http.c around the http_url_type declaration at line 47 and mrb_http_object_headers_set_item around line 490. Rebuild mruby-http with the warning shown in the issue and determine why each symbol is unused. Done means the reported unused-variable and unused-function warnings no longer appear.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.