mattn / mattn/go-stackbuilder

Document (and probably reverse) the ordering of Handlers

Open
#1 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
7
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Right now, the second handler in the stack wraps the first handler, while the third handler wraps the second one, and so on. Thus when a request comes in, the handler that's last in the argument list actually receives the control over the request first.

It's just my opinion, but I think the order should be reverse, so the first handler in the list processes requests first (and responses last, in turn). See Django's middleware ordering.

The chosen ordering should also be documented in the README.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the README and trace the handler composition to confirm which argument receives a request first and which handles the response last. Decide whether to reverse that ordering, update the implementation if needed, and document the chosen behavior in the README; done means the ordering is consistent and clearly documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.