mattn / mattn/go-sqlite3

linking against system library with sqlite_icu on openbsd

Open
#1,018 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
9.2k
Forks
1.2k
Avg merge
19m
Merged PRs (30d)
4

Description

https://github.com/mattn/go-sqlite3/blob/ae2a61f847e10e6dd771ecd4e1c55e0421cdc7f9/sqlite3_opt_icu.go#L15

@gjrtimmer I know this was quite a while ago, but do you remember why this change was added? If you are using the sqlite_icu build tag then you ought to be statically compiling in our version, so linking against the system version seems counter-intuitive. Was this intentional?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with sqlite3_opt_icu.go at the linked line and inspect why the sqlite_icu build tag links against the system library on OpenBSD. Compare that behavior with the intended static compilation of the bundled version; done means the linking choice is explained and any needed correction is covered by the project's relevant build or integration checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, sqlite
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.