mattn / mattn/emmet-vim

Invalid Br Tag in jsx mode

Open
#381 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Vim Script
Stars
6.5k
Forks
414
PR merge metrics
No merged PRs in 30d

Description

Hello,

I just realised that in jsx mode when I do

br

and expand it I get:

<br>

And this is not valid jsx.

I would expect either: <br/> or <br></br>.

Thank you very much

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the expansion of br in JSX mode and inspect the mode-specific expansion path in emmet-vim. Confirm the change by verifying that the result is valid JSX, using either a self-closing <br/> or an explicitly closed element.

Written by the indexing model from the issue text.

Assessment

Tech stack
html, javascript, vim
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.