mattn / mattn/efm-langserver

feature request - add way to filter by filename is in root path

Open
#257 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
1.6k
Forks
62
PR merge metrics
No merged PRs in 30d

Description

currently the rootMarkers/requireMarker filter is:

			if dir := matchRootPath(fname, cfg.RootMarkers); dir == "" && cfg.RequireMarker == true {

i think this means:
only format / lint if rootMarker EXISTS in any parent dir

This request is to add a new feature

			if dir := matchParentPath(fname, cfg.ParentMarkers); dir == "" && cfg.RequireParentMarker == true {

such that
only format / lint if file is INSIDE a parentMarker dir

e.g.
actionlint should only run for the following parentMarkers = .github/

.github/
    - workflows/
        - abc.yml -- YES
    - FUNDING.yml -- YES
.vintrc.yml -- NO! not in .github/
.yamllint.yml -- NO

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the existing root-marker handling around matchRootPath, cfg.RootMarkers, and RequireMarker, then inspect where configuration fields are defined. Trace how actionlint currently decides whether to run, and verify the requested parent-marker behavior against the .github/ examples. Done means files inside the configured parent-marker directory are selected while matching files outside it are skipped.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devtools, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.