matthewmueller / matthewmueller/date

Today is tomorrow

Open
#92 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.5k
Forks
85
PR merge metrics
No merged PRs in 30d

Description

Today at 1am, comes up as tomorrow at one, for example it is 3/19 right now, but if I do "today at 1am" it gives me 3/20 1am,

I am in cst, and tested it when my timezone is the same day as utc, so it does not seem to be a timezone issue

describe("today issue", function() { it("test today", () => { const date = parse("today at 1am"); console.log(d(date), d(new Date())); assert(d(date) == d(new Date())); }); });

the console.log is
3/20/19 3/19/19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the reported parse("today at 1am") reproduction and compare its date with new Date() in the parser's entry point. Trace how the today expression and hour are interpreted; done means early-morning times remain on the current calendar day and the provided assertion passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.