matthewmueller / matthewmueller/date

"3.99" is interpreted as 4.39am

Open
#71 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.5k
Forks
85
PR merge metrics
No merged PRs in 30d

Description

var date = require('date.js'); console.log(date('3.99'));

This gives the output Wed Jan 06 2016 04:39:00 GMT+0530 (India Standard Time)

Shouldn't such strings indicate invalid time? What do you think?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the date('3.99') example from the issue and inspect the date parsing entry point that accepts this string. Determine whether the observed interpretation should be rejected as invalid, then add coverage for the expected behavior and run the relevant test suite.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.