mattermost / mattermost/react-native-paste-input
Issues with Expo 53 + new arch
Nobody has claimed this yet.
- Dominant language
- Objective-C
- Stars
- 213
- Forks
- 38
- Avg merge
- 12h 25m
- Merged PRs (30d)
- 1
Description
While upgrading our app to Expo 53 + new arch, we've noticed some issues with version 0.8.1 this package (latest at this time).
On the iOS side we were seeing compilation failures due to changes from two upstream PRs:
- https://github.com/facebook/react-native/pull/47205
- https://github.com/facebook/react-native/pull/48133
Looking at the changes there, I was able to come up with this patch that made things compile again: https://gist.github.com/Ashoat/14a98badc16afc4ed297288a01a69f6e
On the Android side, I saw a runtime error when opening a PasteInput, which was fixed in #40. I was able to fix this by patching the same fix locally, but would be good if a release was published with the fix.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the patch in the linked gist alongside the two React Native upstream PRs, then inspect the changes from #40 for the Android fix. Verify that the package builds on iOS with Expo 53 and that opening a PasteInput works on Android. Done means both fixes are included and a release is published.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- objective-c, react-native
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100