mattermost / mattermost/react-native-emm

`getManagedConfig` documentation outdated

Open
#26 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
18
Forks
7
Avg merge
1h 52m
Merged PRs (30d)
1

Description

The getManagedConfig function in the README is documented as returning a Promise (async function), but the actual implementation in recent versions is synchronous.

https://github.com/mattermost/react-native-emm/blob/f6e57ff80789e36a3bc534f3aed65bbe9b9a4989/src/emm.ts#L42

It would be great to resolve this mismatch between documentation and implementation.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the README entry for getManagedConfig and compare it with the implementation in src/emm.ts at the linked commit. Update the documentation to describe its synchronous return behavior, then check the README for consistent wording.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
documentation, mobile
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.