mattermost / mattermost/mattermost-plugin-gitlab
Support config variable to disable project access check for incoming webhook event
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 152
- Forks
- 97
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 8
Description
At the moment, we ensure a given user has read access to a project when:
- the user creates a subscription
- a webhook event comes in to be processed with the subscriptions
There are some issues going on with revoked tokens, causing existing subscriptions to not work in the second case. https://github.com/mattermost/mattermost-plugin-gitlab/issues/411#issuecomment-1927033155
The task here is to implement a plugin config variable "Enable Webhook Project Access Check", which will default to `true`. When this value is `false`, we will skip the project access check when we receive a webhook event
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the plugin configuration and incoming webhook event-processing paths described in the issue, and trace where the project access check is performed. Add the “Enable Webhook Project Access Check” setting with a true default, then verify that false skips the check while true preserves it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100