mattermost / mattermost/mattermost-plugin-gitlab
Add warning for webhook to the readme + obsolete link provided by /gitlab setup webhook + non-compatible with gitlab mattermost guide
@raghavaggarwal2308 is already working on this.
Since Dec 19, 2024.
- Dominant language
- JavaScript
- Stars
- 152
- Forks
- 97
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 8
Description
From the experience of setting up Mattermost + GitLab integration:
* https://docs.gitlab.com/ee/integration/mattermost/ oauth redirect is not the same which is required by this plugin. However, gitlab documentation is linked even from official mattermost webpages as a recommended tutorial.
* Self hosted (same network) instance of the gitlab has in default set `Allow requests to the local network from webhooks and integrations` to `False`; however, this option has to be set to True or Mattermost site has to be mentioned in the list there. in `mygitlab.example.com/admin/application_settings/network` -- it would be nice to mention this in the README
* When setting calling `/gitlab setup` the wizard is providing hint in the form of links to the README. However, it appeared to me, that the links `refs` (the think behind `#`) is pointing to some older version of the README file. *I can not confirm this, since I managed to configure everything and I am not willing to break it in order to find the message.* :smile:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.