mattermost / mattermost/mattermost-plugin-github
Pop-over displays too low on on first attempt if there is not enough vertical space below the post
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 179
- Forks
- 180
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 13
Description
There is an issue where the GitHub pop-over shows too low and is unreadable if the post is too low in the thread and there is not enough vertical space to show it.
It seems on the 1st attempt, the pop-over will always display below the post. On the 2nd attempt it will correctly display upward as it does not fit below. This should always happen.
First pop-over attempt:
Second pop-over attempt:
Note: I (@DHaussermann ) am unsure if this can be fixed in GitHub or if it's a webapp issue.
Steps:
-
Open a channel in Mattermost
-
Make a post with a GitHub link ex: https://github.com/mattermost/mattermost-plugin-apps/pull/230
-
Hold your mouse pointer over the link
Observed The pop-over is displayed downward and cannot be read.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by opening a Mattermost channel, posting the example GitHub link, and hovering over it near the bottom of the thread. Trace the GitHub link pop-over entry point and compare the first and second display attempts; done means the first attempt opens upward when there is insufficient space below and remains readable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, go
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100