mattermost / mattermost/mattermost-plugin-github

Only channel admins should be able to create subscription

Open
#488 4 comments 1 reaction 1 assignee View on GitHub

@raghavaggarwal2308 is already working on this.

Since Nov 4, 2024.

Difficulty/1:Easy Good First Issue Hacktoberfest Help Wanted Tech/Go Type/Enhancement Up For Grabs
Dominant language
Go
Stars
179
Forks
180
Avg merge
1d 16h
Merged PRs (30d)
13

Description

At the moment, any user can create/edit/delete GitHub subscriptions. This functionality should be limited to users with permission to manage the given channel. The following cases should allow a user to edit subscriptions:

  • The channel is a private channel and the user has PERMISSION_MANAGE_PRIVATE_CHANNEL_PROPERTIES for this channel
  • The channel is a public channel and the user has PERMISSION_MANAGE_PUBLIC_CHANNEL_PROPERTIES for this channel
  • The channel is a direct message (DM)
  • The channel is a group message (GM)

Issue created from a Mattermost message by @hanzei.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.