mattermost / mattermost/mattermost-plugin-github
Notifications for comments on commits have an invalid link
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 179
- Forks
- 180
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 13
Description
The link of a a comment in [this PR](https://github.com/mattermost/mattermost-plugin-incident-response/pull/291), specifically on [this commit](https://github.com/mattermost/mattermost-plugin-incident-response/commit/0a1b4c94837f9e821080d2918c873c524c792dfd) is broken. The plugin is linking to
https://github.com/mattermost/mattermost-plugin-incident-response/0a1b4c94837f9e821080d2918c873c524c792dfd#issuecomment-42623107
but the real link should be
https://github.com/mattermost/mattermost-plugin-incident-response/pull/291#commitcomment-42623107
_Issue created from a [Mattermost message](https://community.mattermost.com/_redirect/pl/rgipqgsuj7g3tyo4iqn7gx9ode) *by @agarciamontoro*._
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the GitHub notification link construction for comments on commits and reproduce the case using the commit and pull request URLs in the issue. Trace how the comment ID is incorporated into the generated link; done means commit comments open the pull request's commit-comment URL rather than the invalid repository-root URL.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, go
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100