mattermost / mattermost/mattermost-plugin-github
Notifications do not respect organization lock
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 179
- Forks
- 180
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 13
Description
When the plugin is configured to be locked to a specific repo, a user can still receive notifications from at mentions is other repos
This may not necessarily be a bug but it is not consistent with the To do list and other functionality of the plugin.
This does not appear to be a regression from the current release.
1. Connect tests user
2. Lock the plugin to specific organization
3. As a different GitHub user at mention the test user in a different org or account
**Observed**: Notifications are delivered from the bot
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by tracing the organization or repository lock check for GitHub at-mention notifications, then reproduce the three-step scenario with two users and separate organizations. Done means an at mention outside the configured scope does not deliver a bot notification, with a regression test covering it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, go
- Domain
- authorization, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100