mattermost / mattermost/mattermost-plugin-github

GitHub username should not be shown in profile popup, if post is from webhook

Open
#264 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Difficulty/2:Medium Hacktoberfest Help Wanted Needs Mattermost Changes Tech/ReactJS Type/Bug Up For Grabs
Dominant language
Go
Stars
179
Forks
180
Avg merge
1d 16h
Merged PRs (30d)
13

Description

A post created from a webhook still shows the custom attributes. Given that the post belongs to the webhook and only indirectly to the user, custom attributes should not be shown for webhook posts.

![Screenshot from 2020-05-11 10-00-25](https://user-images.githubusercontent.com/16541325/81538565-2fc03500-936f-11ea-81df-38cfd1308ac6.png)
![Screenshot from 2020-05-11 10-00-32](https://user-images.githubusercontent.com/16541325/81538560-2e8f0800-936f-11ea-9a85-407c24a212f2.png)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by tracing the profile popup's handling of posts created from webhooks and compare it with ordinary posts. Done means webhook posts no longer expose custom attributes or the GitHub username in that popup, with relevant tests updated or added if coverage exists.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, go
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.