mattermost / mattermost/mattermost-plugin-github

Avoid double fetching post data

Open
#206 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Difficulty/1:Easy Hacktoberfest Help Wanted Tech/ReactJS Type/Enhancement Up For Grabs
Dominant language
Go
Stars
179
Forks
180
Avg merge
1d 16h
Merged PRs (30d)
13

Description

NOTE: This PR must be merged before code will appear in master. If it is merged, feel free to take!

I suggest we have this component receive the post (or even just postMessage if we don't need anything else) so we can avoid a double fetch to the API to get the post.

Relevant lines of code are linked below.

https://github.com/mattermost/mattermost-plugin-github/pull/123/files/cc4ed0749ae13f9c7ea2a71592e666d7cbfd22aa#diff-71ba01315c638d511aa23811dcd1c081R15

Originally posted by @marianunez in https://github.com/mattermost/mattermost-plugin-github/pull/123

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with pull request 123 and the linked diff, then trace the component and post-data flow described in issue 206. Confirm where the API fetch is repeated and verify that the component uses the already available post data without changing the resulting behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, go
Domain
api, backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.