matter-labs / matter-labs/zksync-protocol
PorterStorage demux branch remains partially wired while scheduler hard disables zkporter
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 22
- Forks
- 21
- Avg merge
- 12h 46m
- Merged PRs (30d)
- 2
Description
PorterStorage is still present in the log demux and queue plumbing, but the production scheduler explicitly disables zkporter.
Relevant code:
PorterStoragebranch exists incrates/zkevm_circuits/src/demux_log_queue/mod.rs- it is marked unimplemented via
DemuxOutput::is_implemented() == false - scheduler enforces
zkporter_is_available == falseincrates/zkevm_circuits/src/scheduler/mod.rs
Suggested fix:
- either remove/feature gate the Porter-specific demux path entirely
- or add explicit invariants everywhere this branch is reachable so future enablement cannot happen accidentally
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the PorterStorage branch in crates/zkevm_circuits/src/demux_log_queue/mod.rs with DemuxOutput::is_implemented(), then trace the scheduler guard in crates/zkevm_circuits/src/scheduler/mod.rs. Determine whether the branch should be removed or feature-gated, or whether explicit invariants are required. Done means the disabled zkporter path cannot be enabled accidentally.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100